fix: Snapshot QueryableBuffer error #25673
Merged
+175
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug in queryable buffer where if a block of data was missing one of the columns defined in a table sort key, the creation of the logical plan to sort and dedupe the data would fail, causing a panic. Fixes #25670
pauldix
force-pushed
the
pd/buffer-persist-error
branch
from
4430744 to
fe1a22a
Compare
pauldix
changed the title
hiltontj
approved these changes
Dec 17, 2024
|
I believe we are ok with it. Although maybe the should be empty strings? |
|
I'm going to merge for now, but we may always want to have an empty string for any series key value not present. Logged #25674 to discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in queryable buffer where if a block of data was missing one of the columns defined in a table, the creation of the logical plan to sort and dedupe the data would fail, causing a panic.
Fixes #25670