Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common.shim): Add batch to shim #16148

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

revilon1991
Copy link

Summary

I want to use batch with shim within the method Write.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #11902
resolves #10277

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 5, 2024

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@revilon1991
Copy link
Author

!signed-cla

Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
@DStrand1
Copy link
Member

@revilon1991 Thanks for the PR! I see you commented for the CLA checker, but I don't see your username in the list. Could you double check that you submitted that? Thanks!

@DStrand1 DStrand1 self-assigned this Nov 13, 2024
@revilon1991
Copy link
Author

@DStrand1 which list? I don't know what I should do else

@revilon1991 revilon1991 changed the title add batch shim for output.execd feat(common.shim): Add batch to shim Nov 29, 2024
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Nov 29, 2024
@revilon1991
Copy link
Author

!signed-cla


"github.com/influxdata/telegraf"
"github.com/influxdata/telegraf/models"
"github.com/influxdata/telegraf/plugins/parsers/influx"
)

type batchMetrics struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should better be in its own file together with specific tests for each of the methods (add, clear, len)

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.31 % for linux amd64 (new size: 262.4 MB, nightly size 256.5 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External plugin does not adhere to metric_batch_size shim trigger output to write single metric
3 participants