-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common.shim): Add batch to shim #16148
base: master
Are you sure you want to change the base?
Conversation
Thanks so much for the pull request! |
!signed-cla |
26b356d
to
2cedc7c
Compare
2cedc7c
to
f6ed0af
Compare
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
@revilon1991 Thanks for the PR! I see you commented for the CLA checker, but I don't see your username in the list. Could you double check that you submitted that? Thanks! |
@DStrand1 which list? I don't know what I should do else |
!signed-cla |
|
||
"github.com/influxdata/telegraf" | ||
"github.com/influxdata/telegraf/models" | ||
"github.com/influxdata/telegraf/plugins/parsers/influx" | ||
) | ||
|
||
type batchMetrics struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should better be in its own file together with specific tests for each of the methods (add
, clear
, len
)
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
I want to use batch with shim within the method
Write
.Checklist
Related issues
resolves #11902
resolves #10277