Skip to content

Commit

Permalink
feat: ephemeral notebook link (#2906)
Browse files Browse the repository at this point in the history
  • Loading branch information
drdelambre authored Oct 18, 2021
1 parent 0073faa commit 3cfb566
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/dashboards/components/dashboard_index/DashboardCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,16 @@ class DashboardCard extends PureComponent<Props> {
},
} = this.props

let dest = `/notebook/from/dashboard/${id}`

if (!isFlagEnabled('boardWithFlows')) {
dest = `/orgs/${orgID}/dashboards/${id}`
}

if (e.metaKey) {
window.open(`/orgs/${orgID}/dashboards/${id}`, '_blank')
window.open(dest, '_blank')
} else {
history.push(`/orgs/${orgID}/dashboards/${id}`)
history.push(dest)
}

onResetViews()
Expand Down
2 changes: 2 additions & 0 deletions src/shared/selectors/flags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export const OSS_FLAGS = {
'notification-endpoint-telegram': false,
'molly-first': false,
exploreWithFlows: false,
boardWithFlows: false,
createWithFlows: false,
leadWithFlows: false,
notebooksExp: false,
Expand Down Expand Up @@ -92,6 +93,7 @@ export const CLOUD_FLAGS = {
'notification-endpoint-telegram': false,
'molly-first': false,
exploreWithFlows: false,
boardWithFlows: false,
createWithFlows: false,
leadWithFlows: false,
notebooksExp: false,
Expand Down

0 comments on commit 3cfb566

Please sign in to comment.