Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zero step size bug in unwrap_error_phase_closure #1067

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Aug 9, 2023

Description of proposed changes

Reminders

+ replace np.rint() with np.ceil() to ensure non-zero step size, which could happen for long time-series with highly redundant networks.
@yunjunz yunjunz changed the title fix zero step size in unwrap_error_phase_closure fix zero step size bug in unwrap_error_phase_closure Aug 9, 2023
@yunjunz yunjunz merged commit 559b8d7 into insarlab:main Aug 9, 2023
4 checks passed
@yunjunz yunjunz deleted the bugfix branch August 9, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A problem about calculating the number of non-zero closure phase
1 participant