-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for concurrent modification exception on removing table #78
base: master
Are you sure you want to change the base?
Fix for concurrent modification exception on removing table #78
Conversation
Enhanced code to filter quantiles based on user choice Included --cql-ssl option to crated encrypted native connection Added latest version of jars as the older version are having some vulnerabilities
Used netty 4.1.42.Final to be inline with another PR
…le-filter The master branch contains some important fixes.
Applied quantile filtering while writing metrics into socket. Corrected formating. Reverted netty jar version changes.
Appended the new line at the end of files which removed while restoring previous changes from repo.
Percentile filter
Filter all excluded metrics
This PR fixes the issue #77 |
Would it be possible to reproduce the issue in a unit test? That way it would be easy to verify the fix, and to make sure that the issue is not re-introduced in a future refactoring. Also, your PR contain a range of different changes. Perhaps it will be easier for maintainers to review/merge your PR if you can extract your fix into a separate branch before you create the PR. |
Lot of mocking required to initialize and call the method reconcileMBeans of the class JMXHarvester as the constructor itself triggering lot of functionality through metadataFactory. Since the fix I made is very simple and straight forward,I would prefer not to add any test case in this particular case. Sorry for the inconvenience made by the rage of changes in my PR, I pulled all merged changes form zegelin/cassandra-exporter as it contains important fixes. I will find a better way next time. |
3b88272
to
84cb7cd
Compare
Fix for the issue #77
I am able reproduce the issue with below code snippet.
`package com.zegelin.cassandra.exporter;
import com.google.common.collect.Sets;
import java.util.Set;
public class TestSets {
}
`