Add support for managing organization ip allow list entries (Fixes #1067) #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglascayers
commented
Oct 3, 2022
| @@ -91,6 +91,17 @@ func buildChecksumID(v []string) string { | |||
| return fmt.Sprintf("%x", bs) | |||
| } | |||
|
|
|||
| func expandNestedSet(m map[string]interface{}, target string) []string { | |||
There was a problem hiding this comment.
🧹 Moved from github/util_v4.go because this isn't v4 api specific (as far as I can tell) and looked similar to the expandStringList func that was here, too.
douglascayers
commented
Oct 3, 2022
| @@ -10,17 +11,6 @@ type PageInfo struct { | |||
| HasNextPage bool | |||
| } | |||
|
|
|||
| func expandNestedSet(m map[string]interface{}, target string) []string { | |||
There was a problem hiding this comment.
douglascayers
commented
Oct 3, 2022
Comment on lines
+48
to
+50
| func githubv4IsNodeNotFoundError(err error) bool { | ||
| return err != nil && strings.HasPrefix(err.Error(), "Could not resolve to a node with the global id") | ||
| } |
douglascayers
commented
Oct 3, 2022
| * Returns all IP allow list entries for an organization. | ||
| * This util function is used by both data_source and resource elements. | ||
| */ | ||
| func getOrganizationIpAllowListEntries(meta interface{}) ([]IpAllowListEntry, error) { |
There was a problem hiding this comment.
This logic was moved fromdata_source_github_organization_ip_allow_list.go because I wanted to make use of this data in the resource.
My first attempt was having the resource call the datasource function but I felt that was too tightly coupled and a bit hacky.
|
Thanks @douglascayers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
github/config.gonodeIdwhich is required with graphql (v4) api callsiddatabase id is primarily for rest (v3) api callsgithub/provider.goandgithub/resource_github_organization_ip_allow_list.gogithub_organization_ip_allow_list_entryresource to read/create/update/delete ip allow list entriesgithub/util_v4.goandgithub/util.goutil.gogithub/util_v4_organization_ip_allow_list.gogithub/data_source_github_organization_ip_allow_list.goTests
TODO
How to Test
TODO
Test Output
Usage
Example configuration: