Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unit tests #5

Merged
merged 12 commits into from
Jan 11, 2024
Merged

feat: Unit tests #5

merged 12 commits into from
Jan 11, 2024

Conversation

brian-intel
Copy link
Contributor

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/core-services/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/core-services )

Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
…d, add unit-test output to the dockerfile

Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
… files

Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
@brian-intel brian-intel added the enhancement New feature or request label Jan 8, 2024
…be used during tests

Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
@brian-intel brian-intel merged commit 9b8c7e4 into intel-retail:main Jan 11, 2024
4 of 6 checks passed
@brian-intel brian-intel deleted the unitTests branch January 11, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant