Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python capi bindings #8

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

brian-intel
Copy link
Contributor

@brian-intel brian-intel commented Jun 3, 2024

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/core-services/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Adding python bindings for c-capi. This includes the docker image build to compile to .so file and an example python program to get you started.

Issue this PR will close

close: #7

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

  • make build ovms-build-image
  • make build-capi-python
  • make run
  • cd /tmp/project
  • cp /output/ovmspybind.so .
  • python3 ovms-pybind.py
  • See isLive status True in a loop

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/core-services )

Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
@brian-intel brian-intel added enhancement New feature or request 3.1 labels Jun 3, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

capi-python/ovms-pybind.cpp Outdated Show resolved Hide resolved
capi-python/ovms-pybind.cpp Outdated Show resolved Hide resolved
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
@brian-intel brian-intel merged commit 7bf327e into intel-retail:main Jun 5, 2024
5 of 6 checks passed
@brian-intel brian-intel deleted the pythonCAPIBindings branch June 5, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 3.0: Python C-API bindings for core-services
2 participants