Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding second ROI and alert logic #19

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

antoniomtz
Copy link
Contributor

@antoniomtz antoniomtz commented Nov 7, 2024

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/loss-prevention/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

  1. make download-models (if applicable)
  2. make build
  3. make INPUTSRC=https://github.com/openvinotoolkit/openvino_notebooks/raw/refs/heads/recipes/recipes/automated_self_checkout/data/example.mp4 PIPELINE_SCRIPT=yolov8s_roi.sh run-render-mode
  4. make logs
  5. Watch when apple leave BAGGING region of interest and alert shows at the logs.

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/loss-prevention )

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz antoniomtz added the enhancement New feature or request label Nov 7, 2024
@antoniomtz antoniomtz self-assigned this Nov 7, 2024
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- tested and worked, just very minor code readability changes

src/extensions/gva_roi_metadata.py Show resolved Hide resolved
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz antoniomtz merged commit e32b6e1 into intel-retail:main Nov 8, 2024
4 checks passed
@antoniomtz antoniomtz deleted the second-roi branch November 8, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants