Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yolov8 support with ROI and tracking #7

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

antoniomtz
Copy link
Contributor

@antoniomtz antoniomtz commented Sep 17, 2024

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/loss-prevention/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

  1. make build (required)
  2. make download-models
  3. make INPUTSRC=https://github.com/intel-iot-devkit/sample-videos/raw/master/people-detection.mp4 PIPELINE_SCRIPT=yolov8s_roi.sh run-render-mode

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/loss-prevention )

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@@ -32,7 +32,7 @@ DECODE="${DECODE:="decodebin force-sw-decoders=1"}" #decodebin|vaapidecodebin
DEVICE="${DEVICE:="CPU"}" #GPU|CPU|MULTI:GPU,CPU

show_help() {
echo "usage: \"--pipeline_script_choice\" requires an argument yolov5s.sh|yolov5s_effnetb0.sh|yolov5s_full.sh|people_detection.sh"
echo "usage: \"--pipeline_script_choice\" requires an argument yolov5s.sh|yolov5s_effnetb0.sh|yolov5s_full.sh|people_detection.sh|yolov8s_roi.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we can look at refactoring out the ASC pipelines

download-models: download-yolov8s
./download_models/downloadModels.sh

download-yolov8s:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great method for doing this!

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
Copy link
Contributor

@seanohair22 seanohair22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works! Just found one grammatical spelling error

smoke_test.sh Outdated
@@ -16,6 +16,8 @@ setup() {
make clean-all || true
echo "Build Loss Prevention image"
make build
echo "Downlaod models"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Downlaod models"
echo "Download models"

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz antoniomtz merged commit b9a43df into intel-retail:main Sep 19, 2024
4 checks passed
@antoniomtz antoniomtz deleted the yolov8-support branch September 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants