-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance stream-density mode for the benchmark script to take multiple target_fps and container_names #72
feat: enhance stream-density mode for the benchmark script to take multiple target_fps and container_names #72
Conversation
553fbfe
to
6fe9331
Compare
…ntainer_names for parallel running different case pipelines for stream density mode and added unit tests Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
6fe9331
to
7467912
Compare
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ran successfully
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code worked after I made changes in requirements file. I got following 2 exceptions with versions for numpy & pandas -
ERROR: No matching distribution found for numpy>=1.25.0
ERROR: No matching distribution found for pandas>=2.1.0
After I removed the version, everything worked fine.
what python version you use? the docs from here uses 3.12.x: https://github.com/intel-retail/documentation/blob/main/docs_src/performance-tools/benchmark.md |
I have 3.8 version. That explains the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM!
this pr to add new capabilities for parallel running different case pipelines for stream density mode and added unit tests
PR Checklist
What are you changing?
Issue this PR will close
close: #issue_number
Anything the reviewer should know when reviewing this PR?
Test Instructions if applicable
cd ./benchmark-scripts
make init-packages
make python-test
you should see all unit tests are PASSED and OK
make python-coverage
so that you can see the code coverage of the stream_density.py
If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/performance-tools )