Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance stream-density mode for the benchmark script to take multiple target_fps and container_names #72

Conversation

jim-wang-intel
Copy link
Contributor

@jim-wang-intel jim-wang-intel commented Nov 7, 2024

this pr to add new capabilities for parallel running different case pipelines for stream density mode and added unit tests

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/performance-tools/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

  • git clone this PR
  • change directory to benchmark-scripts: cd ./benchmark-scripts
  • re-build the python packages:
make init-packages
  • run unit tests:
make python-test

you should see all unit tests are PASSED and OK

  • run coverage:
make python-coverage

so that you can see the code coverage of the stream_density.py

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/performance-tools )

@jim-wang-intel jim-wang-intel force-pushed the multiple-pipeline-stream-density branch 6 times, most recently from 553fbfe to 6fe9331 Compare November 7, 2024 19:41
@jim-wang-intel jim-wang-intel added enhancement New feature or request 3.2 labels Nov 7, 2024
…ntainer_names for parallel running different case pipelines for stream density mode and added unit tests

Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Copy link

@antoniomtz antoniomtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran successfully

Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Copy link

@NeethuES-intel NeethuES-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code worked after I made changes in requirements file. I got following 2 exceptions with versions for numpy & pandas -

ERROR: No matching distribution found for numpy>=1.25.0
ERROR: No matching distribution found for pandas>=2.1.0

After I removed the version, everything worked fine.

@jim-wang-intel
Copy link
Contributor Author

Code worked after I made changes in requirements file. I got following 2 exceptions with versions for numpy & pandas -

ERROR: No matching distribution found for numpy>=1.25.0
ERROR: No matching distribution found for pandas>=2.1.0

After I removed the version, everything worked fine.

what python version you use? the docs from here uses 3.12.x: https://github.com/intel-retail/documentation/blob/main/docs_src/performance-tools/benchmark.md

@NeethuES-intel
Copy link

Code worked after I made changes in requirements file. I got following 2 exceptions with versions for numpy & pandas -

ERROR: No matching distribution found for numpy>=1.25.0
ERROR: No matching distribution found for pandas>=2.1.0

After I removed the version, everything worked fine.

what python version you use? the docs from here uses 3.12.x: https://github.com/intel-retail/documentation/blob/main/docs_src/performance-tools/benchmark.md

I have 3.8 version. That explains the error.

Copy link
Contributor

@seanohair22 seanohair22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

@jim-wang-intel jim-wang-intel merged commit 633b619 into intel-retail:main Nov 13, 2024
6 of 10 checks passed
@jim-wang-intel jim-wang-intel deleted the multiple-pipeline-stream-density branch November 13, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants