Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated testcontainers and docker in go.mod, resolves dependabot vulnerabilities #114

Merged

Conversation

seanohair22
Copy link
Contributor

@seanohair22 seanohair22 commented Aug 13, 2024

PR Checklist

Author Mandatory (to be filled by PR Author/Submitter)

CODE MAINTAINABILITY

  • Commit Message meets guidelines as indicated in the URL*
  • Tests for the changes have been added (required for bug fixes / features). If not, state why not
  • Added labels (these are git labels such as bug or enhancement)
  • For any API changes or service changes, updates to the documentation were made (Swagger APIs & GitHub Docs). If not, state why not
  • Every commit is a single defect fix and does not mix feature addition or changes*

What are the steps to test this PR contribution?

How does a reviewer know it works?

  1. Check that only docker compose v2 is installed with docker compose version
  2. Run make integration-test ... observe no errors."

Are there any special instructions beyond standard workflow?

Maintainer Mandatory (to be filled by PR Reviewer/Approving Maintainer)

QUALITY CHECKS

  • Quality of code (At least one should be checked as applicable)*
    • Commit Message meets guidelines
    • Code copyright is correct
    • PR changes adhere to industry practices and standards as well as domain or language specific anti-patterns
    • Adopted domain specific coding standards (Go Coding Standards)
    • Code is adequately commented and documented
    • Confusing logic is explained in comments
    • Error and exception code paths implemented correctly
    • Tracing output are minimized and logic
  • Test coverage shows adequate coverage with required CI functional tests pass on all supported platforms*
  • Static code scan report shows zero critical issues*

Other information

@seanohair22 seanohair22 added dependencies Pull requests that update a dependency file go Pull requests that update Go code test Includes tests dependabot labels Aug 13, 2024
@seanohair22 seanohair22 self-assigned this Aug 13, 2024
@seanohair22 seanohair22 marked this pull request as ready for review August 13, 2024 23:12
@seanohair22 seanohair22 requested a review from a team as a code owner August 13, 2024 23:12
Copy link
Contributor

@antoniomtz antoniomtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanohair22 seanohair22 merged commit d41d8db into intel:main Aug 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependabot dependencies Pull requests that update a dependency file go Pull requests that update Go code test Includes tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants