Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: updated geti sdk #117

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix: updated geti sdk #117

merged 1 commit into from
Oct 16, 2024

Conversation

antoniomtz
Copy link
Contributor

PR Checklist

Author Mandatory (to be filled by PR Author/Submitter)

CODE MAINTAINABILITY

  • [x ] Commit Message meets guidelines as indicated in the URL*
  • Tests for the changes have been added (required for bug fixes / features). If not, state why not
  • [x ] Added labels (these are git labels such as bug or enhancement)
  • For any API changes or service changes, updates to the documentation were made (Swagger APIs & GitHub Docs). If not, state why not
  • Every commit is a single defect fix and does not mix feature addition or changes*

What are the steps to test this PR contribution?

How does a reviewer know it works?

Are there any special instructions beyond standard workflow?

Bug:
#116

Maintainer Mandatory (to be filled by PR Reviewer/Approving Maintainer)

QUALITY CHECKS

  • Quality of code (At least one should be checked as applicable)*
    • Commit Message meets guidelines
    • Code copyright is correct
    • PR changes adhere to industry practices and standards as well as domain or language specific anti-patterns
    • Adopted domain specific coding standards (Go Coding Standards)
    • Code is adequately commented and documented
    • Confusing logic is explained in comments
    • Error and exception code paths implemented correctly
    • Tracing output are minimized and logic
  • Test coverage shows adequate coverage with required CI functional tests pass on all supported platforms*
  • Static code scan report shows zero critical issues*

Other information

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz antoniomtz added the bug Something isn't working label Oct 16, 2024
@antoniomtz antoniomtz self-assigned this Oct 16, 2024
@antoniomtz antoniomtz requested a review from a team as a code owner October 16, 2024 21:37
@antoniomtz antoniomtz linked an issue Oct 16, 2024 that may be closed by this pull request
Copy link

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoniomtz antoniomtz merged commit 28217df into intel:main Oct 16, 2024
7 checks passed
@antoniomtz antoniomtz deleted the update-geti-sdk branch October 16, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Geti pipelines fail using geti models v2.0 and above
3 participants