Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address inconsistencies/timing issues with GitHub Actions Testing #24

Merged
merged 7 commits into from
Sep 18, 2023

Conversation

seanohair22
Copy link
Contributor

PR Checklist

Author Mandatory (to be filled by PR Author/Submitter)

CODE MAINTAINABILITY

  • Commit Message meets guidelines as indicated in the URL*
  • Tests for the changes have been added (required for bug fixes / features). N/A
  • Added labels (these are git labels such as bug or enhancement)
  • For any API changes or service changes, updates to the documentation were made (Swagger APIs & GitHub Docs). *N/A
  • Every commit is a single defect fix and does not mix feature addition or changes*

What are the steps to test this PR contribution?

How does a reviewer know it works?

  • Go to Actions tab in repo, click on Unit and Integration Tests, view the following run

Are there any special instructions beyond standard workflow?

Maintainer Mandatory (to be filled by PR Reviewer/Approving Maintainer)

QUALITY CHECKS

  • Quality of code (At least one should be checked as applicable)*
    • Commit Message meets guidelines
    • Code copyright is correct
    • PR changes adhere to industry practices and standards as well as domain or language specific anti-patterns
    • Adopted domain specific coding standards (Go Coding Standards)
    • Code is adequately commented and documented
    • Confusing logic is explained in comments
    • Error and exception code paths implemented correctly
    • Tracing output are minimized and logic
  • Test coverage shows adequate coverage with required CI functional tests pass on all supported platforms*
  • Static code scan report shows zero critical issues*

Other information

Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
@seanohair22 seanohair22 added dependencies Pull requests that update a dependency file test Includes tests labels Sep 7, 2023
@seanohair22 seanohair22 marked this pull request as ready for review September 12, 2023 22:17
@seanohair22 seanohair22 requested a review from a team as a code owner September 12, 2023 22:17
Copy link
Contributor

@antoniomtz antoniomtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanohair22 seanohair22 merged commit bafaece into main Sep 18, 2023
2 checks passed
@seanohair22 seanohair22 deleted the update_GHA_runner branch September 18, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file test Includes tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants