measure performance: fix increase default maximum limit of multistream. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvrogozh
requested changes
Oct 9, 2020
measure/performance/MSPerf.py
Outdated
| @@ -137,7 +137,7 @@ def main(): | |||
| ################################# Variable Assignment ################################################# | |||
| starting_streamnumber = str(ARGS.startStreams) if ARGS.startStreams else "all:1" | |||
| maximum_iteration = int(ARGS.numbers_of_iteration) if ARGS.numbers_of_iteration else 1 | |||
| endStreams = int(ARGS.endStreams) if ARGS.endStreams else 99 | |||
| endStreams = int(ARGS.endStreams) if ARGS.endStreams else 999999 | |||
There was a problem hiding this comment.
I think you are setting the default in a wrong place (and for other options as well!). Instead you need to do that during option declarations. I.e.:
parser.add_argument('-e', '--endStreams', default=999999, help='To set ending number of multi stream performance measurement')
<...>
endStreams = ARGS.endStreams
Could you, please, rework options declarations in general taking above into account?
Signed-off-by: James Iwan <james.iwan@intel.com>
jamesiwan
force-pushed
the
fix_default_max_multistream
branch
from
ae2665f
to
7665c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Iwan james.iwan@intel.com