Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter 9 - Tutorials on ROHD Verification Framework #407

Merged
merged 15 commits into from
Sep 21, 2023
Merged

Chapter 9 - Tutorials on ROHD Verification Framework #407

merged 15 commits into from
Sep 21, 2023

Conversation

quekyj
Copy link
Contributor

@quekyj quekyj commented Sep 8, 2023

Description & Motivation

This chapter will show the user how to verify hardware design using ROHD-VF.

Related Issue(s)

None

Testing

None

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

None

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

None

mkorbel1
mkorbel1 requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

doc/tutorials/chapter_9/rohd_vf.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_9/rohd_vf.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_9/rohd_vf.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_9/rohd_vf.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_9/rohd_vf.md Show resolved Hide resolved
doc/tutorials/chapter_9/rohd_vf.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_9/rohd_vf.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_9/uvm.dart Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@quekyj quekyj requested a review from mkorbel1 September 14, 2023 07:51
mkorbel1
mkorbel1 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once you resolve the CI failure!

doc/tutorials/chapter_9/rohd_vf.md Outdated Show resolved Hide resolved
@quekyj
Copy link
Contributor Author

quekyj commented Sep 19, 2023

@mkorbel1 It seems the errors in CI can be ignored?

@mkorbel1
Copy link
Contributor

@mkorbel1 It seems the errors in CI can be ignored?

Perhaps we can just add it as a folder to ignore in the analysis options?

mkorbel1
mkorbel1 reviewed Sep 20, 2023
View reviewed changes
analysis_options.yaml Outdated Show resolved Hide resolved
mkorbel1
mkorbel1 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mkorbel1 mkorbel1 merged commit 3e7139f into intel:main Sep 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quekyj @mkorbel1