Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SystemVerilog parameter passthroughs #497

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

Even though SystemVerilog parameters are not supported for controlling anything within generated outputs of SystemVerilog, sometimes there is a need to pass parameters down through a ROHD-generated hierarchy into ExternalSystemVerilog modules. This PR provides that capability.

Related Issue(s)

N/A

Testing

Added new tests, plus existing tests

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Yes!

The API for SystemVerilog has changed, including default behavior. This PR occurs between releases, however, so this is not a delta over previous releases since no release yet has SystemVerilog. This may impact people pointing at main.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Not really any user guide stuff, the documentation on advanced features is not very deep and refers to the API docs, which were updated.

@mkorbel1 mkorbel1 merged commit aeab8ed into intel:main Jul 9, 2024
3 checks passed
@mkorbel1 mkorbel1 deleted the sv_param_passthrough branch July 9, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant