Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inputSource and inOutSource to Module #503

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Aug 3, 2024

Description & Motivation

Adds new APIs to Module to access the original "driver" or "source" when an input or inOut port was created.

See #501 for more information on motivation, etc.

Also, removed the @protected on various APIs related to accessing inputs and inOuts on Modules since (a) it wasn't really protecting much during hardware generation since modules could access it without lint warning, and (b) because the proper use and connectivity of the APIs is already dependent on user understanding of in/out rules for module building.
 

Related Issue(s)

Fix #501

Testing

Add tests for new APIs + existing tests to make sure nothing broke

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Variable name changes from x to source on port creation APIs may trigger warnings on overrides of those functions, but not breaking.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit d41029e into intel:main Aug 6, 2024
3 checks passed
@mkorbel1 mkorbel1 deleted the inputsource branch August 6, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide API to access the "driver" of Module input and inOut ports
1 participant