Add inputSource
and inOutSource
to Module
#503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Adds new APIs to
Module
to access the original "driver" or "source" when an input or inOut port was created.See #501 for more information on motivation, etc.
Also, removed the
@protected
on various APIs related to accessing inputs and inOuts on Modules since (a) it wasn't really protecting much during hardware generation since modules could access it without lint warning, and (b) because the proper use and connectivity of the APIs is already dependent on user understanding of in/out rules for module building.Related Issue(s)
Fix #501
Testing
Add tests for new APIs + existing tests to make sure nothing broke
Backwards-compatibility
Variable name changes from
x
tosource
on port creation APIs may trigger warnings on overrides of those functions, but not breaking.Documentation
No