Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and improve Uniquifier API #505

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Aug 14, 2024

Description & Motivation

The Uniquifier in ROHD is useful in many situations, but not exposed as a public API of ROHD (yet?). Because it is private, the API is a little bit confusing as it relates to reserved items and was also not heavily unit tested.

This PR:

  • Adds better testing for the Uniquifier
  • Upgrades the isAvailable API to properly consider whether a reserved item should be considered available or not
  • Optimizes the implementation to be a little more performant, since it is called many times

Related Issue(s)

Related to #134, but not closing it

Testing

Added new tests, and existing tests help protect that nothing broke

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Only if someone relied on the weird API behavior of an internal utility of ROHD

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit 3e2d24a into intel:main Aug 22, 2024
3 checks passed
@mkorbel1 mkorbel1 deleted the uniqupgrade branch August 22, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant