Upgrade and improve Uniquifier
API
#505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
The
Uniquifier
in ROHD is useful in many situations, but not exposed as a public API of ROHD (yet?). Because it is private, the API is a little bit confusing as it relates to reserved items and was also not heavily unit tested.This PR:
isAvailable
API to properly consider whether a reserved item should be considered available or notRelated Issue(s)
Related to #134, but not closing it
Testing
Added new tests, and existing tests help protect that nothing broke
Backwards-compatibility
Only if someone relied on the weird API behavior of an internal utility of ROHD
Documentation
No