-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow LogicNet
s to bidirectionally drive operations which are just wires
#532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility, add tests
mkorbel1
changed the title
Allow
Allow Nov 25, 2024
LogicNet
s to bidirectionally use "gates" which are just wiresLogicNet
s to bidirectionally drive operations which are just wires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
There are numerous operations on signals which in reality only represent wires. For example:
Since there's no real logic on the path, it makes sense for
LogicNet
s to support bidirectional driving across these gates. Additionally, some things (especially subsets and swizzles) are crucial for useful routing ofLogicNet
signals for connectivity -- otherwise only full-bus could be used effectively.This PR introduces changes so that
LogicNet
s can have bidirectional driving through these gates. It also fixes SystemVerilog generation so that the SV matches the behavior of the ROHD simulator with these new features.Some other misc changes:
Related Issue(s)
Fix #518
Defer #530 to later (prettier SV)
Testing
Added extensive testing for new functionality.
Backwards-compatibility
LogicNet
s has changed, but it was arguably broken before, and not released previously (yet).Const
constructor updated so that specifiedwidth
takes precedence over the inherent width of a providedLogicValue
val
.Documentation
Updated user guide and CHANGELOG, in addition to the usual API doc updates.