fix: properly parse converters for hybrid commands #1476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Who know that the complex prefixafication of slash commands could lead to bugs?
I (somewhat) kid of course. Regardless, this PR fixes one such bug - it turns out that I was assuming
SlashCommandParameter.converter
was, well, aConverter
, when in reality it's actually the equivalent of theconvert
function inside of the converter (which is done so that we don't waste time initing a converter every single time... that can get quite time consuming). The hybrid command parser did not account for this, so I went back to make it do so.Changes
second_converter
in the chain converters are functions, not actual converters. This has the extra benefit of getting rid of an import and simplifying the code.Related Issues
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files