Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap timestamp converter #1477

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: wrap timestamp converter #1477

merged 1 commit into from
Jul 10, 2023

Conversation

LordOfPolls
Copy link
Contributor

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Wraps timestamp's converter to handle stupid values like 269533-01-01T00:00

Changes

  • Return MISSING if timestamp converter hits a ValueError

Related Issues

image

https://discord.com/channels/789032594456576001/1126845035133030441/1126845035133030441

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

AstreaTSS
AstreaTSS approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate how this has to exist

@LordOfPolls
Copy link
Contributor Author

Welcome to discord i guess

@LordOfPolls LordOfPolls merged commit 61f34d8 into unstable Jul 10, 2023
10 of 11 checks passed
@LordOfPolls LordOfPolls deleted the timestamp_valueerror branch July 10, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstreaTSS AstreaTSS AstreaTSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordOfPolls @AstreaTSS