Give mutable class attributes typing.ClassVar signatures
#1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## unstable #1497 +/- ##
============================================
- Coverage 58.25% 58.19% -0.07%
============================================
Files 143 143
Lines 15296 15297 +1
============================================
- Hits 8911 8902 -9
- Misses 6385 6395 +10
☔ View full report in Codecov by Sentry. |
AstreaTSS
approved these changes
Jul 19, 2023
i0bs
added a commit
that referenced
this pull request
Aug 8, 2023
* feat: add args, kwargs to task (#1478) * modified: interactions/models/internal/tasks/task.py * reset to set_last_call_time Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> --------- Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> * feat: add id attr to app perms update event * revert: commit signoff err * ci: show pre-commit diff on failure (#1484) * feat: add alt methods for multi-arg params for prefixed cmds (#1471) * feat: add alt methods for multi-arg params for prefixed cmds * fix: use empty if the typehint is just tuple * ci: correct from checks. * fix: support ConsumeRest without typehint --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: cache channel data from interactions (#1479) * fix: account for BaseChannel for channel mentions (#1480) * feat: add default to delete/edit init interaction msg (#1481) * docs: remove outdated cookiecutter template (#1483) * docs: remove outdated cookiecutter template * docs: add boilerplate mention * feat: add id attr to app perms update event (#1485) * feat: add sort order for forums (#1488) * feat: add forum sort order * feat: cache layout and sort order for forums * feat: add rate limit per user where needed (#1489) Signed-off-by: LordOfPolls <dev@lordofpolls.com> * fix: use message channel for PrefixedContext (#1491) * fix: bound app_permissions for HybridContext (#1492) * feat: add start_time(s) for AutoShardedClient (#1482) * feat: add start_time(s) for AutoShardedClient * feat: make start_times a dict * docs: make start_times docstring clearer Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> * fix: correct listen typehint (#1495) * chore: move mutable class ref/attrs to ClassVar typing (#1497) * ci: weekly check. (#1460) * ci: weekly check. updates: - https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit - [github.com/astral-sh/ruff-pre-commit: v0.0.272 → v0.0.278](astral-sh/ruff-pre-commit@v0.0.272...v0.0.278) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: add ability to use different arg name than option name (#1493) * feat: add ability to use different arg name than option name * feat: raise better error if arg name doesnt exist * fix: use ValueError instead of TypeError TypeError seems to be suppressed * fix: make sure exported auto_defer is deco, not module (#1496) * fix/feat: adjust invite obj to respect event variants (#1500) * fix/feat: adjust invite obj to respect event variants * docs: update docs for event object * revert: keep MISSING for backwards compatibility * style: consistency Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> * fix: address issues with tag usage for guild forums (#1499) * fix: address issues with tags for guild forums * fix: is this breaking? better be safe than sorry * docs💥: revamp extension guide (#1494) * docs💥: revamp extension guide * docs: update extension example * docs: oops, forgot a word Co-authored-by: Max <maxyolo01.ytb@gmail.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> * docs: add section for loading all extensions in folder * docs: turns out ipy can load multi exts in one file * docs: lots of wording adjustments --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Max <maxyolo01.ytb@gmail.com> Co-authored-by: LordOfPolls <dev@lordofpolls.com> * feat: add `guild` & `channel` properties to `ThreadMembersUpdate` (#1504) * ci: weekly check. (#1503) * ci: weekly check. updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.278 → v0.0.280](astral-sh/ruff-pre-commit@v0.0.278...v0.0.280) * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(http): incorrect path for delete permission endpoint (#1506) * fix delete_permissions api endpoint fix API Endpoint in delete_channel_permission adding "permissions/" in Endpoint * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci: weekly check. (#1511) updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.280 → v0.0.281](astral-sh/ruff-pre-commit@v0.0.280...v0.0.281) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: Implement missing stuff for scheduled events (#1507) * feat: Implement gateway support for scheduled events * fix: add optional to user add/remove * refactor: pre-commit'ed * refactor: change attrs to props and add `attrs.field` * refactor: set repr to True * feat(client): add `get_scheduled_event` helper method * refactor: use cache helpers in methods * chore: replace typing * docs: clarify intents in example (#1516) * feat: infer modal/component callback names from coroutine (#1519) * feat: infer callback decor from coroutine name * docs: add new logic notation * chore: add doc notation to component callback definition * docs: clarify intents for extensions * ci: weekly check. (#1521) updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.281 → v0.0.282](astral-sh/ruff-pre-commit@v0.0.281...v0.0.282) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> Signed-off-by: LordOfPolls <dev@lordofpolls.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: kennhh <133614589+kennhh@users.noreply.github.com> Co-authored-by: i0bs <41456914+i0bs@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: LordOfPolls <dev@lordofpolls.com> Co-authored-by: Max <maxyolo01.ytb@gmail.com> Co-authored-by: Damego <damego.dev@gmail.com> Co-authored-by: Donbur4156 <janpfister@t-online.de>
i0bs
added a commit
that referenced
this pull request
Aug 8, 2023
* feat: add args, kwargs to task (#1478) * modified: interactions/models/internal/tasks/task.py * reset to set_last_call_time Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> --------- Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> * feat: add id attr to app perms update event * revert: commit signoff err * ci: show pre-commit diff on failure (#1484) * feat: add alt methods for multi-arg params for prefixed cmds (#1471) * feat: add alt methods for multi-arg params for prefixed cmds * fix: use empty if the typehint is just tuple * ci: correct from checks. * fix: support ConsumeRest without typehint --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: cache channel data from interactions (#1479) * fix: account for BaseChannel for channel mentions (#1480) * feat: add default to delete/edit init interaction msg (#1481) * docs: remove outdated cookiecutter template (#1483) * docs: remove outdated cookiecutter template * docs: add boilerplate mention * feat: add id attr to app perms update event (#1485) * feat: add sort order for forums (#1488) * feat: add forum sort order * feat: cache layout and sort order for forums * feat: add rate limit per user where needed (#1489) Signed-off-by: LordOfPolls <dev@lordofpolls.com> * fix: use message channel for PrefixedContext (#1491) * fix: bound app_permissions for HybridContext (#1492) * feat: add start_time(s) for AutoShardedClient (#1482) * feat: add start_time(s) for AutoShardedClient * feat: make start_times a dict * docs: make start_times docstring clearer Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> * fix: correct listen typehint (#1495) * chore: move mutable class ref/attrs to ClassVar typing (#1497) * ci: weekly check. (#1460) * ci: weekly check. updates: - https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit - [github.com/astral-sh/ruff-pre-commit: v0.0.272 → v0.0.278](astral-sh/ruff-pre-commit@v0.0.272...v0.0.278) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: add ability to use different arg name than option name (#1493) * feat: add ability to use different arg name than option name * feat: raise better error if arg name doesnt exist * fix: use ValueError instead of TypeError TypeError seems to be suppressed * fix: make sure exported auto_defer is deco, not module (#1496) * fix/feat: adjust invite obj to respect event variants (#1500) * fix/feat: adjust invite obj to respect event variants * docs: update docs for event object * revert: keep MISSING for backwards compatibility * style: consistency Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> * fix: address issues with tag usage for guild forums (#1499) * fix: address issues with tags for guild forums * fix: is this breaking? better be safe than sorry * docs💥: revamp extension guide (#1494) * docs💥: revamp extension guide * docs: update extension example * docs: oops, forgot a word Co-authored-by: Max <maxyolo01.ytb@gmail.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> * docs: add section for loading all extensions in folder * docs: turns out ipy can load multi exts in one file * docs: lots of wording adjustments --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Max <maxyolo01.ytb@gmail.com> Co-authored-by: LordOfPolls <dev@lordofpolls.com> * feat: add `guild` & `channel` properties to `ThreadMembersUpdate` (#1504) * ci: weekly check. (#1503) * ci: weekly check. updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.278 → v0.0.280](astral-sh/ruff-pre-commit@v0.0.278...v0.0.280) * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(http): incorrect path for delete permission endpoint (#1506) * fix delete_permissions api endpoint fix API Endpoint in delete_channel_permission adding "permissions/" in Endpoint * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci: weekly check. (#1511) updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.280 → v0.0.281](astral-sh/ruff-pre-commit@v0.0.280...v0.0.281) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: Implement missing stuff for scheduled events (#1507) * feat: Implement gateway support for scheduled events * fix: add optional to user add/remove * refactor: pre-commit'ed * refactor: change attrs to props and add `attrs.field` * refactor: set repr to True * feat(client): add `get_scheduled_event` helper method * refactor: use cache helpers in methods * chore: replace typing * chore: pyproject version bump --------- Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> Signed-off-by: LordOfPolls <dev@lordofpolls.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Signed-off-by: Sophia <41456914+i0bs@users.noreply.github.com> Co-authored-by: kennhh <133614589+kennhh@users.noreply.github.com> Co-authored-by: i0bs <41456914+i0bs@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: LordOfPolls <dev@lordofpolls.com> Co-authored-by: Max <maxyolo01.ytb@gmail.com> Co-authored-by: Damego <damego.dev@gmail.com> Co-authored-by: Donbur4156 <janpfister@t-online.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
#1460 is currently invalidated by pre-commit due to ruff warnings. This PR proposes explicit type signatures to class attribute declarations that only mutate after definition and before
__init__.Changes
Singleton._instances->ClassVar[dict]WebSocketClosed.codes->ClassVar[List[int, str]]VoiceWebSocketClosed.codes->ClassVar[List[int, str]]Metadata.requirements->ClassVar[list]Related Issues
Test Scenarios
Tests are not required, as we are dealing with only tooling here.
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files