Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: simplekv unpin #251

Merged
merged 1 commit into from
Mar 13, 2018
Merged

setup: simplekv unpin #251

merged 1 commit into from
Mar 13, 2018

Conversation

jacquerie
Copy link
Contributor

Version 0.11.2 of simplekv restored the old behavior of accepting
keys of type str in Python 2.

@jacquerie jacquerie requested a review from hachreak September 22, 2017 15:11
@hachreak
Copy link
Member

hachreak commented Sep 26, 2017

mbr/flask-kvsession#43 (comment)

Maybe if they can release the new flask-kvsession, we can remove the dependency. 😄

@jacquerie
Copy link
Contributor Author

Maybe if they can release the new flask-kvsession, we can remove the dependency. 😄

Yes, I prefer this solution too! So I opened a PR there: mbr/flask-kvsession#45. Hopefully we will get a quick merge and release, and then I will amend this PR to just remove this line.

@lnielsen lnielsen added this to the v1.0.0 milestone Mar 10, 2018
@lnielsen lnielsen self-assigned this Mar 12, 2018
@lnielsen
Copy link
Member

lnielsen commented Mar 12, 2018

Waiting for fix of build on master (which is being fixed as part of the current Invenio sprint).

* Version 0.11.2 of simplekv restored the old behavior of accepting
  keys of type ``str`` in Python 2.

Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@gmail.com>
@lnielsen lnielsen merged commit ff7d64e into inveniosoftware:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants