Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin flask-mail #63

Merged
merged 1 commit into from
May 28, 2024
Merged

pin flask-mail #63

merged 1 commit into from
May 28, 2024

Conversation

anikachurilova
Copy link
Member

@anikachurilova anikachurilova commented May 27, 2024 •
edited
Loading

@ptamarit
Copy link
Member

ptamarit commented May 27, 2024 •
edited
Loading

Since there is a breaking change in Flask-Mail, should we bump the minimum required version in setup.cfg to 0.10.0?

kpsherva
kpsherva reviewed May 27, 2024
View reviewed changes
invenio_mail/ext.py Outdated
@@ -16,7 +16,7 @@
from . import config


def print_email(message, app):
def print_email(app, message):
Copy link
Contributor

@kpsherva kpsherva May 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing how flask mail implements it, should it follow their signature?

Suggested change
def print_email(app, message):
def print_email(app, message=None):

EDIT: change to None, mistake when copying

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand the suggested change: Flask-Mail will call print_email(app, message=message), but we cannot use message=message in a method definition.
The way this Pull Request is implemented follows the official Signalling support documentation, so it looks fine to me.

ptamarit
ptamarit approved these changes May 27, 2024
View reviewed changes
invenio_mail/ext.py Outdated
@@ -16,7 +16,7 @@
from . import config


def print_email(message, app):
def print_email(app, message):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand the suggested change: Flask-Mail will call print_email(app, message=message), but we cannot use message=message in a method definition.
The way this Pull Request is implemented follows the official Signalling support documentation, so it looks fine to me.

@anikachurilova anikachurilova force-pushed the fix-print-mail branch 3 times, most recently from 027c488 to 4434cfa Compare May 28, 2024 09:07
@anikachurilova anikachurilova changed the title change print_mail method signature pin flask-mail May 28, 2024
@kpsherva kpsherva closed this May 28, 2024
@kpsherva kpsherva reopened this May 28, 2024
@anikachurilova anikachurilova force-pushed the fix-print-mail branch 5 times, most recently from 964e071 to 4f7e41f Compare May 28, 2024 12:12
@kpsherva kpsherva merged commit 100348f into inveniosoftware:master May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpsherva kpsherva kpsherva left review comments

@ntarocco ntarocco ntarocco approved these changes

@ptamarit ptamarit ptamarit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deposit form: share draft
4 participants
@anikachurilova @ptamarit @ntarocco @kpsherva