Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module activation store interface #1641

Merged

Conversation

notaphplover
Copy link
Member

Description

  • ModuleActivationStore has been updated with missing generics.
  • Container has been updated to stop relying on unexpected private property accesses.
  • Docs have been updated to no longer reflect injectable is not mandatory.

Motivation and Context

  • Provide more accurated types.
  • Avoid private property accesses from other classes.
  • Fix misleading changelog notes.

How Has This Been Tested?

  • Test passes successfully.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

update ModuleActivationStore
update _getContainerModuleHelpersFactory to avoid private property access
@notaphplover notaphplover self-assigned this Nov 18, 2024
@notaphplover notaphplover merged commit d4cd32b into master Nov 18, 2024
8 checks passed
@notaphplover notaphplover deleted the refactor/update-module-activation-store-interface branch November 18, 2024 15:46
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (3e19129) to head (5af0cff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1641   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          50       50           
  Lines        1498     1499    +1     
  Branches      192      192           
=======================================
+ Hits         1491     1492    +1     
  Misses          4        4           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant