Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spec_helper #73

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix spec_helper #73

merged 2 commits into from
Oct 16, 2023

Conversation

tot-ioki
Copy link
Contributor

This will require 'active_support' in spec helper to make the specs run again. It also fixes formatting a time with timezone by using to_fs instead of to_s.

This issue was introduced by merging #61 although the PR itself was green.

@tot-ioki tot-ioki added the bug Something isn't working label Oct 16, 2023
@tot-ioki tot-ioki self-assigned this Oct 16, 2023
@tot-ioki tot-ioki requested a review from a team October 16, 2023 07:52
pak-ioki
pak-ioki approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@pak-ioki pak-ioki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding

@tot-ioki tot-ioki merged commit 2ba130e into main Oct 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pak-ioki pak-ioki pak-ioki approved these changes

Assignees

@tot-ioki tot-ioki

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tot-ioki @pak-ioki