Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade to stencil 4 #1257

Merged
merged 2 commits into from
Sep 12, 2023
Merged

chore(deps): upgrade to stencil 4 #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e5f8f
chore(deps): upgrade to stencil 4
sean-perkins Aug 21, 2023
3e9b65a
chore: disable sourcemaps
sean-perkins Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"test.spec": "stencil test --spec"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want source map generation? This is enabled by default in Stencil 3. I recall there being some issues in Framework that made us disable it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I disabled it for the same reasoning we disabled it for PWA elements: ionic-team/pwa-elements#125

"dependencies": {
"@stencil/core": "^2.18.0"
"@stencil/core": "^4.0.3"
},
"devDependencies": {
"@playwright/test": "^1.33.0",
Expand Down
1 change: 1 addition & 0 deletions stencil.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Config } from '@stencil/core';
export const config: Config = {
namespace: 'ionicons',
buildEs5: 'prod',
sourceMap: false,
outputTargets: [
{
type: 'dist',
Expand Down