test: refactor to use toHaveScreenshot #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested review from
a team and
thetaPC
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Playwright tests to use the newer
toHaveScreenshotAPI instead oftoMatchSnapshot. The newer API produces smaller file sizes and reduces the flakiness of tests.I also fixed an issue with one of our CI scripts. Currently, if a single test runner does not have any screenshots to update (but others potentially do) that single test runner will fail because a .zip is not created. I fixed this by verifying that the zip is only created if the
updated-screenshotsdirectory is not empty.