Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to FSharp.Core 7+ and newer FSharp.CompilerServices #69

Merged
merged 1 commit into from
May 16, 2023

Conversation

DamianReeves
Copy link
Contributor

This fixes issues where even the Options example in this repo doesn't work if you are using dotnet7

@bigjonroberts
Copy link

Nice

@bigjonroberts
Copy link

I just tried this out on Windows 10 with dotnet sdk version 7.0.101 and had a similar error as #66 .
I'll try it out under debug later this weekend and see if I can get the detailed error message.
The Analyzers need to output more detailed error messages to allow easier diagnosis of issues like this. I might put in a PR for that ...

image

@DamianReeves
Copy link
Contributor Author

I just tried this out on Windows 10 with dotnet sdk version 7.0.101 and had a similar error as #66 . I'll try it out under debug later this weekend and see if I can get the detailed error message. The Analyzers need to output more detailed error messages to allow easier diagnosis of issues like this. I might put in a PR for that ...

image

I think I had to do a -c Release when I ran.

@baronfel
Copy link
Collaborator

Sorry for the delay here - thanks for tackling this @DamianReeves!

@baronfel baronfel merged commit 8d83cf1 into ionide:master May 16, 2023
@DamianReeves DamianReeves deleted the amplifying-fsharp branch May 16, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants