Skip to content

Commit

Permalink
Bump version to 7.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
baronfel committed Sep 24, 2022
1 parent 774ea9d commit 68dd5e5
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 19 deletions.
10 changes: 9 additions & 1 deletion release/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
### 7.2.0 - 24.08.2022

* [Group discovered tests by namespace](https://github.com/ionide/ionide-vscode-fsharp/pull/1766) (thanks @kojo12228!)
* [Many](https://github.com/ionide/ionide-vscode-fsharp/pull/1775), [many](https://github.com/ionide/ionide-vscode-fsharp/pull/1776) [fixes](https://github.com/ionide/ionide-vscode-fsharp/pull/1777) to the add and remove files functionality (thanks @MangelMaxime!)
* [Added support for gitpod](https://github.com/ionide/ionide-vscode-fsharp/pull/1779) (thanks @purkhusid!)
* Update and use FSAC 0.57.2 to pick up many fixes, especially for .net 6 and .net 7 SDK support. Changes can be seen at the release notes for [0.57.0](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.57.0), [0.57.1](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.57.1), and [0.57.2](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.57.2).

### 7.1.0 - 19.08.2022
* Update FSAC to 0.56.12 for [these changes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.56.2)

* Update FSAC to 0.56.2 for [these changes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.56.2)
* Removed unused FAKE configuration settings and handler code
* Massively improve error messages when dotnet isn't found (thanks @MangelMaxime!)
* Improve FSI management (thanks @MangelMaxime!)
Expand Down
6 changes: 3 additions & 3 deletions release/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,7 @@
"command": "fsharp.explorer.addExistingFile",
"group": "2_modifications@2",
"when": "viewItem == ionide.projectExplorer.project"
},
},
{
"command": "fsharp.explorer.project.generateFSI",
"group": "3_fsi@1",
Expand Down Expand Up @@ -1596,5 +1596,5 @@
"type": "git",
"url": "https://github.com/ionide/ionide-vscode-fsharp.git"
},
"version": "7.1.0"
}
"version": "7.2.0"
}
31 changes: 16 additions & 15 deletions src/Core/LanguageService.fs
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@ Consider:
let req: FsProj.DotnetFileRequest =
{ FsProj = fsproj
FileVirtualPath = file }

cl.sendRequest ("fsproj/addExistingFile", req)
|> Promise.map (fun (res: Types.PlainNotification) -> ())

Expand Down Expand Up @@ -708,21 +709,21 @@ Consider:
let fsacPath = fsacPathForTfm tfm
printfn "Parsed TFM to fsac path: %s" fsacPath
return [], [], fsacPath
// if v.major >= 6.0 then
// // when we run on a sdk higher than 6.x (aka what FSAC is currently built/targeted for),
// // we have to tell the runtime to allow it to actually run on that runtime (instead of presenting 6.x as 5.x)
// // in order for msbuild resolution to work
// let args = [ "--roll-forward"; "LatestMajor" ]

// let envs =
// if v.prerelease <> null || v.prerelease.Count > 0 then
// [ "DOTNET_ROLL_FORWARD_TO_PRERELEASE", box 1 ]
// else
// []

// return args, envs, fsacPath
// else
// return [], [], fsacPath
// if v.major >= 6.0 then
// // when we run on a sdk higher than 6.x (aka what FSAC is currently built/targeted for),
// // we have to tell the runtime to allow it to actually run on that runtime (instead of presenting 6.x as 5.x)
// // in order for msbuild resolution to work
// let args = [ "--roll-forward"; "LatestMajor" ]

// let envs =
// if v.prerelease <> null || v.prerelease.Count > 0 then
// [ "DOTNET_ROLL_FORWARD_TO_PRERELEASE", box 1 ]
// else
// []

// return args, envs, fsacPath
// else
// return [], [], fsacPath
}

let userDotnetArgs = "FSharp.fsac.dotnetArgs" |> Configuration.get [||]
Expand Down

0 comments on commit 68dd5e5

Please sign in to comment.