ISC - Restructure and Edit docs #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename core_contracts to core-contracts * edit tone and content for wasp-cli
* edit EVM * fix links in Wasm
* rename core_contracts to core-contracts * edit tone and content for wasp-cli
* edit EVM * fix links in Wasm
luca-moser
requested changes
Sep 14, 2023
docs/build/wasp-evm/0.7.0/docs/getting-started/compatibility.md
Outdated
Show resolved
Hide resolved
docs/build/wasp-evm/0.7.0/docs/how-tos/magic-contract/call-a-native-contract.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Luca Moser <me@lucamoser.ch>
Co-authored-by: Luca Moser <me@lucamoser.ch>
Added experimental tag to switcher for wasp-wasm Added links to stardust protocol and shimmer endpoints in emv/intro and wasm/intro Replaced ShimmerEVM Testnet with Public Testnet and link to networks and endpoints in evm getting-started sections Added link to off-ledger and on-ledger request explanations in evm-getting/started/compatibility Removed redundant paragrpah in how-tos/magic-contract/call-a-native-contract Added link to magic_contract ref in wasp-evm/0.7.0/docs/how-tos/magic-contract/magic.md Removed redundant explanation in emv/explanations/concepts Added average block time in evm/compatibility
|
/create-preview |
|
This pull request has been deployed to Vercel. Latest commit: ✅ Preview: https://iota-wiki-qm8ijv78p-iota1.vercel.app |
Dr-Electron
reviewed
Sep 20, 2023
docs/build/wasp-evm/0.7.0/docs/getting-started/compatibility.md
Outdated
Show resolved
Hide resolved
Comment on lines
+63
to
+64
| Unlike Ethereum's blockchain that houses the state in a Merkle tree, the EVM state resides in a raw form to prevent the | ||
| duplication of efforts undertaken by the ISC layer. |
Co-authored-by: Dr-Electron <dr-electr0n@protonmail.com>
luca-moser
previously approved these changes
Sep 22, 2023
|
Please resolve the conflicts so we can get this merged. |
Dr-Electron
requested changes
Sep 22, 2023
lucas-tortora
dismissed stale reviews from luca-moser and fijter
via
b5df882
|
/create-preview |
|
This pull request has been deployed to Vercel. Latest commit: ✅ Preview: https://iota-wiki-4zt5bfvco-iota1.vercel.app |
Dr-Electron
approved these changes
Sep 22, 2023
If they were the same plugin we could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Restructured ISC docs:
wasp-clito the build section.Links to any relevant issues
fixes iotaledger/devx#214
fixes iotaledger/devx#213
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.