Tutorial: Cross-chain NFT marketplace

[salaheldinsoliman]

Description of change

A cross-chain NFT marketplace: Part I

Links to any relevant issues

fixes #1625

Type of change

• Documentation Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own changes
• I have made sure that added/changed links still work
• I have commented my code, particularly in hard-to-understand areas

[jorgemmsilva]

LGTM, could use a few hardhat tests and not just manual testing with scripts, but it's quite nice 👍

[jorgemmsilva]

we will bridge NFTs from BNB Testnet and Shimmer Testnet to the ShimmerEVM Testnet

this is confusing. I think we should make it clear that we're talking about "L1 Shimmer testnet NFTs", maybe moving it into a separate sentence. Or dropping the L1 part in this tutorial entirely

[lucas-tortora]

Suggested change

	In part II, we will bridge NFTs from BNB Testnet and Shimmer Testnet to the ShimmerEVM Testnet and list them on the marketplace.
	The second part of the series will focus on bridging NFTs from Layer 1 networks, like the Shimmer and BNB Testnets, to the ShimmerEVM Testnet and listing them on the marketplace you created in part I.

[lucas-tortora]

Great start :) Please use references for the imports, and explain the contracts and scripts step by step. The idea for tutorials is to teach the user how to do this, more than how to clone the repo and run the scripts. So we need to walk them step by step so they can build their own implementation, while using the repository as an example.

[lucas-tortora]

I think it may be a good idea to move this tutorial into the ISC docs directly, under a new folder called tutorials. There are currently no links pointing to the tutorial section, as lots are outdated.

wdyt?

[salaheldinsoliman]

If the other tutorials are outdated it would be a good idea to separate them yes, until they are given a review to refresh them

[lucas-tortora]

Suggested change

	In this series of tutorials, we will be building a cross-chain NFT marketplace using IOTA Smart Contracts (ISC). The marketplace will allow users to trade NFTs on ShimmerEVM Testnet, BNB Testnet, and Shimmer Testnet.
	This is the first part of a three-part series that will guide you as you build a cross-chain NFT marketplace using IOTA Smart Contracts (ISC). The marketplace will allow users to trade NFTs on the ShimmerEVM Testnet, BNB Testnet, and Shimmer L1 Testnet.

[lucas-tortora]

Suggested change

	In part II, we will bridge NFTs from BNB Testnet and Shimmer Testnet to the ShimmerEVM Testnet and list them on the marketplace.
	The second part of the series will focus on bridging NFTs from Layer 1 networks, like the Shimmer and BNB Testnets, to the ShimmerEVM Testnet and listing them on the marketplace you created in part I.

[lucas-tortora]

Suggested change

	Finally, in part III, we will deploy another instance of the marketplace on the BNB Testnet, making the marketplace truly cross-chain by making the contract handle cross-chain transactions.
	Finally, in part III, you will deploy another instance of the marketplace on the BNB Testnet, making the marketplace truly cross-chain.

[lucas-tortora]

Suggested change

	run it by executing:
	You can run the script by executing the following command:

[lucas-tortora]

Suggested change

	After deploying the MyERC721 contract, let's mint an NFT by running the following script:
	After you have deployed the `MyERC721` contract, you are ready to mint an NFT using the following script:

[lucas-tortora]

Suggested change

	```javascript
	const fs = require('fs');
	const path = require('path');
	async function createNFT(myERC721Address) {
	const MyERC721 = await ethers.getContractFactory("MyERC721");
	const myERC721 = MyERC721.attach(myERC721Address);
	const tx = await myERC721.mint();
	await tx.wait(); // Wait for the transaction to be mined
	}
	async function main() {
	// Read the contract address from the file
	const addressPath = path.join(__dirname, 'addresses', 'MyERC721.txt');
	const myERC721Address = fs.readFileSync(addressPath, 'utf8').trim();
	await createNFT(myERC721Address);
	}
	main()
	.then(() => process.exit(0))
	.catch((error) => {
	console.error(error);
	process.exit(1);
	});
	```
	```javascript reference
	https://github.com/iota-community/ISC-Cross-Chain-NFT-Marketplace/blob/main/scripts/mint_nft.js
	```

[lucas-tortora]

Suggested change

	execute the script by running:
	You can run the script by executing the following command:

[lucas-tortora]

Suggested change

	### approve_myERC721_for_marketplace.js
	### approve_myERC721_for_marketplace.js

[lucas-tortora]

Amazing improvement !!! Last batch of comments on my end :) Btw, you don't need to add the suggestions manually; if you go to the Files tab, hit Add suggestion to batch to the ones you'd like to include and then commit them all at once.

[salaheldinsoliman]

Amazing improvement !!! Last batch of comments on my end :) Btw, you don't need to add the suggestions manually; if you go to the Files tab, hit Add suggestion to batch to the ones you'd like to include and then commit them all at once.

@lucas-tortora All thanks to your comments!
With adding the suggestions manually, I wanted to do that myself in my first article/PR to avoid repeating the same mistakes in future PRs