feat: Cross Chain marketplace partIII #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
|
This pull request has been deployed to Vercel. Latest commit: 0c8e4af ✅ Preview: https://iota-wiki-oc205c9g0-iota1.vercel.app |
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Tortora <85233773+lucas-tortora@users.noreply.github.com>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Co-authored-by: Lucas Tortora <85233773+lucas-tortora@users.noreply.github.com>
lucas-tortora
approved these changes
Aug 20, 2024
vivekjain23
requested changes
Aug 27, 2024
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Show resolved
Hide resolved
| ``` | ||
|
|
||
|
|
||
| ## Scripts |
There was a problem hiding this comment.
In the scripts section, we could also implement a command to verify the deployed contracts, wdyt?
There was a problem hiding this comment.
That would be a good addition yes, but I think it is out of scope for this tutorial.
We would need the APIs for ShimmerEVM and BNBTestnet blockexplorers, and add some extra config to hardhat.config.js.
What would be more suitable is adding this part later on, WDYT?
|
@salaheldinsoliman , are there any blockers on this? It'd be nice to publish the last part of the series :) |
|
@vivekjain23 Can you please approve this If you don't have further comments? thanks! |
vivekjain23
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Part III of the tutorial, finally
Links to any relevant issues
#1663
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.