feat: use new exchange session logic #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of manually creating a session and hoping the DAG we've been passed implements the Session interface, add the session to the context in WalkDepth. This should ensure that _any_ walk has an associated session.
Stebalien
force-pushed
the
feat/context-sessions
branch
from
59b2ffa
to
69158fe
Compare
4 tasks
hsanjuan
reviewed
Apr 23, 2020
Comment on lines
+17
to
+19
| // Deprecated: Use exchange.NewSession to wrap your context. This function only | ||
| // works if the NodeGetter happens to implement the session interface. If it has | ||
| // been wrapped in some way, it won't work. |
There was a problem hiding this comment.
Can you specify how you can then get the session out of the context afterwards too?
Might be worth changing the signature and returning an error when the NodeGetter is not a SessionMaker. People might be using this wrong and the deprecation notice will not really fix their code. Thinking that someone is using this wrong without deep-auditing their code will be difficult for us if they ever ask, and this might be a major perf sink for them even in the simplest application.
There was a problem hiding this comment.
Would a link to the NewSession docs (and some examples there) suffice? I'd like to avoid duplicating information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually creating a session and hoping the DAG we've been passed
implements the Session interface, add the session to the context in WalkDepth.
This should ensure that any walk has an associated session.
part of ipfs/kubo#7198