-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opt-in npm-on-ipfs support #907
Comments
There are some UX challenges to solve here.
I'm sure there are more. @hacdias @ericronne drop any thoughts you have here! |
I agree with the checkbox in settings. Also, I think that on a first run, if we detect that Node.js is installed, we could actively prompt the user. |
So I was implementing this and an issue surged: I was thinking about aliasing We could set an The other option I see is trying to set |
This feels risky. I think we need to do a sanity check around this. Is moving binaries belonging to other packages installed in the system better than adding a directory in front of Unless I am, missing something, |
@lidel I agree that it is risky changing binaries. For now, we decided just to install On Windows it's relatively easy and we already do it to add IPFS to the PATH. |
Something to think about, is that a common developer pattern on Windows is to use WSL (Windows Subsystem for Linux). I have IPFS Desktop installed on Windows and use it for my general use. But then I open WSL Ubuntu and use the Node development tools in there. It has access to all of the local disk and ports. So just detecting PATH= on Windows is not enough, but needs to be more generic. |
@DavidBurela WSL is still running on a separate "world" so it will also be harder for us to detect the presence of Node.js on those situations. What if the user has 3 different distributions, all with Node.js and then they also have Node installed on Windows itself? What would you do? |
I think I misread how it was going to be detected. My thoughts were that all of the environments had access to the IPFS node running on localhost, so that can be used. But after re-reading I realised that IPFS-Desktop simply looks up if it has access to npm, and if it does it tries to run You can ignore my notes. |
This might be a good chance to co-opt @fsdiogo's help system. Each IPFS Experiment could be automatically installed upon release, and the user notified upon app launch, and offered the option to disable it, e.g. … Settings could be home base for managing these add ons. |
As per discussions over on ipfs-shipyard/npm-on-ipfs#94 we'd like make it easy for ipfs-desktop users to try out npm-on-ipfs, and co-host modules that they install.
ipfs-npm
command line toolsnpm
oryarn
The text was updated successfully, but these errors were encountered: