feat: npm on ipfs #911

hacdias · 2019-04-21T22:13:23Z

Please see #907 (comment) (went with the last option).

Merge feat: IPFS experiments UI ipfs-webui#1048
Update Web UI hash

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias · 2019-04-21T22:14:16Z

@lidel @olizilla could you go over the code, see my TODOs and tell me your opinion about those topics, please? Also, if you find something else that looks odd, ask. I want this working the best it can and as reversible as possible. 😃

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

src/late/npm-on-ipfs/index.js

hacdias · 2019-04-22T16:45:51Z

One more note: since we're adding sudo-prompt to #906 (see comments), then we can overcome the permissions issue on Linux here with it too.

Please let's keep this PR to do after #906.

olizilla · 2019-05-02T15:31:06Z

@hacdias did you want to update this PR now that #906 has been merged?

hacdias · 2019-05-02T15:41:03Z

@olizilla I do and I will 😃

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

src/late/npm-on-ipfs/scripts/npm.js

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias · 2019-06-05T08:12:26Z

So we decided to just install ipfs-npm package with this PR and not change anything else in the system. For what is worth, the PR looks finished. We just need a toggler in the UI to install/uninstall ipfs-npm.

@lidel I think we already talked about this: I'm running npm (un)install -g as the user that's running IPFS Desktop. That might not work on all environments. It should work on Windows and macOS, but what about Linux?

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

lidel · 2019-06-05T10:46:44Z

@hacdias I don't want us to spend too much time debugging fringe Linux distributions at this time.
It should work for most people using mainstream defaults, and power users will not mind doing it manually. Just make sure there is proper error handling when npm install -g ipfs-npm fails, asking user to run "npm i -g ipfs-npm" manually. 👌

hacdias · 2019-06-05T11:47:32Z

Completely agree @lidel! Thanks.

So, for this PR to be merged, we only need to wait for ipfs/ipfs-webui#1048 and decide how to send the errors and change the options. Otherwise, it already works.

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

src/late/npm-on-ipfs/index.js

olizilla · 2019-06-06T13:28:46Z

src/late/npm-on-ipfs/package.js

+      return
+    }
+  } catch (e) {
+    logger.error('[npm on ipfs] ipfs-npm: could not check if up to date %v', e)


Maybe throw? we shouldn't let it fall through the next log line.

My idea here was to ignore this error and update it anyways. It will fail for most people due to a bug on npm, which was not yet released: https://github.com/ipfs-shipyard/ipfs-desktop/blob/feat/npm-on-ipfs/src/late/npm-on-ipfs/package.js#L10-L11

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias · 2019-06-11T12:24:52Z

@olizilla could you take one last look at this please?

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias · 2019-06-13T08:51:38Z

Two issues arising on Travis ATM not related to the PR:

https://benlimmer.com/2019/01/14/travis-ci-xvfb/
dist.ipfs.io timing out.

fsdiogo

LGTM 👍

src/late/npm-on-ipfs/index.js

Co-Authored-By: Diogo Silva <fsdiogo@gmail.com>

hacdias · 2019-06-13T18:37:25Z

Travis also failing on master with timeout getting go-ipfs binary. I'm merging this.

andrew · 2019-06-13T19:18:50Z

🎉

hacdias added 4 commits April 21, 2019 23:09

wip: add npm on ipfs support

85cd66a

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

wip: ongoing

c4b980c

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

wip: ongoing

fadc2dd

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

wip: add toggler

3d26899

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

ghost assigned hacdias Apr 21, 2019

ghost added the in progress label Apr 21, 2019

hacdias added 2 commits April 22, 2019 17:13

wip: simplify

3f4744a

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

conflict merge

ce9ae2e

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias commented Apr 22, 2019

View reviewed changes

src/late/npm-on-ipfs/index.js Outdated Show resolved Hide resolved

hacdias mentioned this pull request Apr 22, 2019

feat: ipfs on PATH on runtime #906

Merged

hacdias added 6 commits May 2, 2019 20:56

merge

8d87df4

wip: npm on ipfs

260cd66

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

wip: fix import

4652ada

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

wip: reuse code

1d00f03

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

wip: fix imports

b80781c

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

feat: more cleanup

09c5884

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias commented May 8, 2019

View reviewed changes

src/late/npm-on-ipfs/scripts/npm.js Outdated Show resolved Hide resolved

hacdias added 3 commits May 9, 2019 20:38

wip: remove code

908087c

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

wip: remove some code

bba0426

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

Merge branch 'master' into feat/npm-on-ipfs

1471bc0

hacdias mentioned this pull request May 14, 2019

feat: support config files ipfs-shipyard/npm-on-ipfs#102

Merged

olizilla mentioned this pull request May 17, 2019

The "install via ipfs-desktop" release 💾✨ ipfs-shipyard/npm-on-ipfs#106

Closed

8 tasks

cwaring mentioned this pull request May 27, 2019

feat: IPFS experiments UI ipfs/ipfs-webui#1048

Merged

5 tasks

hacdias added 2 commits June 5, 2019 08:56

Merge branch 'master' into feat/npm-on-ipfs

0bd04d8

feat: add uninstall function

475e667

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias added 2 commits June 5, 2019 10:59

feat: use experiments.npmOnIpfs

1a98c75

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

feat: add npmOnIpfs experiment

ee9497f

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias added 2 commits June 6, 2019 09:58

fix: imports and asyncy

4e1dc3e

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

fix: config evt

0518a7b

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias changed the title ~~wip: npm on IPFS~~ feat: npm on ipfs Jun 6, 2019

hacdias added 2 commits June 6, 2019 11:17

re-add experiments array

710b296

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

remove arary againb

7caccd7

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias mentioned this pull request Jun 6, 2019

Release 0.9 📦 npm-on-ipfs & wild files 🦌 #951

Closed

45 tasks

olizilla reviewed Jun 6, 2019

View reviewed changes

src/late/npm-on-ipfs/index.js Outdated Show resolved Hide resolved

olizilla reviewed Jun 6, 2019

View reviewed changes

feat: check for npm instead

373676d

hacdias mentioned this pull request Jun 10, 2019

Tray Icon - Colors, more info? #956

Closed

hacdias added 2 commits June 11, 2019 09:51

be aware of manual changes

b16ddf8

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

also check when toggling

6093acd

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias requested a review from fsdiogo June 12, 2019 14:58

hacdias added 4 commits June 12, 2019 23:42

update webui hash

d04d75b

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

verify correctly if manually updated

ea7d70f

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

create alias function

2db5ba3

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

try travis service

5eb6e66

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

fsdiogo approved these changes Jun 13, 2019

View reviewed changes

src/late/npm-on-ipfs/index.js Outdated Show resolved Hide resolved

Update src/late/npm-on-ipfs/index.js

4f0f955

Co-Authored-By: Diogo Silva <fsdiogo@gmail.com>

hacdias merged commit ce7291f into master Jun 13, 2019

hacdias deleted the feat/npm-on-ipfs branch June 13, 2019 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: npm on ipfs #911

feat: npm on ipfs #911

hacdias commented Apr 21, 2019 •

edited

Loading

hacdias commented Apr 21, 2019

hacdias commented Apr 22, 2019 •

edited

Loading

olizilla commented May 2, 2019

hacdias commented May 2, 2019

hacdias commented Jun 5, 2019

lidel commented Jun 5, 2019 •

edited

Loading

hacdias commented Jun 5, 2019

olizilla Jun 6, 2019

hacdias Jun 6, 2019

hacdias commented Jun 11, 2019

hacdias commented Jun 13, 2019

fsdiogo left a comment

hacdias commented Jun 13, 2019

andrew commented Jun 13, 2019

feat: npm on ipfs #911

feat: npm on ipfs #911

Conversation

hacdias commented Apr 21, 2019 • edited Loading

hacdias commented Apr 21, 2019

hacdias commented Apr 22, 2019 • edited Loading

olizilla commented May 2, 2019

hacdias commented May 2, 2019

hacdias commented Jun 5, 2019

lidel commented Jun 5, 2019 • edited Loading

hacdias commented Jun 5, 2019

olizilla Jun 6, 2019

Choose a reason for hiding this comment

hacdias Jun 6, 2019

Choose a reason for hiding this comment

hacdias commented Jun 11, 2019

hacdias commented Jun 13, 2019

fsdiogo left a comment

Choose a reason for hiding this comment

hacdias commented Jun 13, 2019

andrew commented Jun 13, 2019

hacdias commented Apr 21, 2019 •

edited

Loading

hacdias commented Apr 22, 2019 •

edited

Loading

lidel commented Jun 5, 2019 •

edited

Loading