fix: correctly handle migration of configs #9995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readPluginsConfig was copied from ReadMigrationConfig and switched erroring fields to a bool so it can be omitemptied.
Jorropo
force-pushed
the
fix-config-migration
branch
from
b6f3650
to
9ebf577
Compare
hacdias
reviewed
Jun 27, 2023
|
@hacdias tests for which of the fix ? |
|
|
|
@hacdias this would be anoying to test you would need to run use an outdated repo and verify kubo starts and migrate. |
hacdias
approved these changes
Jun 27, 2023
|
Gotcha, had missed that it was already copied from somewhere else. Hope it's fine then! |
:D thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readPluginsConfig was copied from ReadMigrationConfig and switched erroring fields to a bool so it can be omitemptied.