Thread bindnode options through convenience calls #572
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a user of the codec helpers might want to be able to use custom bindnode options to assist in Mashalling/Unmarshalling their tyoes
willscott
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
a user of the codec helpers might want to be able to use custom bindnode options to assist in Mashalling/Unmarshalling their types
Implemention
Add opts ...bindnode.Options as parameter to various helpers and pass it through to the underlying bindnode functions.
For discussion
Pretty sure it's fine but passing bindnode options to both prototype call and wrap call in UnmarshalStreaming could have unintended effects? Not sure which is should properly go to though.