Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#524: add more sort method and view method #539

Merged
merged 25 commits into from
Apr 20, 2024
Merged

#524: add more sort method and view method #539

merged 25 commits into from
Apr 20, 2024

Conversation

lidaobing
Copy link
Member

@lidaobing lidaobing commented Apr 17, 2024

  1. add more sort methods: username / host / last_activity
  2. support select info style: IP / username / host / last_activity / last_message
  3. update last_activity after midnight
  4. add sort menu to the context menu of main window

@lidaobing lidaobing linked an issue Apr 17, 2024 that may be closed by this pull request
@lidaobing lidaobing marked this pull request as draft April 17, 2024 05:52
@lidaobing lidaobing self-assigned this Apr 18, 2024
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 63.37580% with 115 lines in your changes are missing coverage. Please review.

Project coverage is 47.08%. Comparing base (7838f30) to head (27e3f3e).

Files Patch % Lines
src/iptux/UiModels.cpp 59.86% 61 Missing ⚠️
src/iptux/MainWindow.cpp 61.29% 48 Missing ⚠️
src/iptux/UiHelper.cpp 83.33% 3 Missing ⚠️
src/iptux/UiModels.h 33.33% 2 Missing ⚠️
src/iptux/UiCoreThread.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
+ Coverage   45.63%   47.08%   +1.44%     
==========================================
  Files          61       63       +2     
  Lines        7901     8068     +167     
==========================================
+ Hits         3606     3799     +193     
+ Misses       4295     4269      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lidaobing lidaobing marked this pull request as ready for review April 20, 2024 18:45
@lidaobing lidaobing changed the title Issue 524 sort #524: add more sort method and view method Apr 20, 2024
@lidaobing lidaobing merged commit 9d87779 into master Apr 20, 2024
18 of 20 checks passed
@lidaobing lidaobing deleted the issue_524_sort branch April 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sort by" Additional Options Needed [By User, By Host]
1 participant