#594: Save Image #595
#594: Save Image #595
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lidaobing - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| GtkTextBuffer* buffer; | ||
| GtkTextTagTable* table; | ||
| GtkTextIter start, end; | ||
| GSList *taglist, *tlist; | ||
|
|
||
| widget = GTK_WIDGET(g_datalist_get_data(&widset, "history-textview-widget")); | ||
| buffer = gtk_text_view_get_buffer(GTK_TEXT_VIEW(widget)); | ||
| buffer = gtk_text_view_get_buffer(chat_history_widget); |
There was a problem hiding this comment.
issue (bug_risk): Potential null pointer dereference
Ensure that chat_history_widget is not null before calling gtk_text_view_get_buffer to avoid potential null pointer dereference.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
=======================================
Coverage 50.28% 50.28%
=======================================
Files 64 64
Lines 8257 8255 -2
=======================================
- Hits 4152 4151 -1
+ Misses 4105 4104 -1 ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 50.28% 51.42% +1.13%
==========================================
Files 64 64
Lines 8257 8333 +76
==========================================
+ Hits 4152 4285 +133
+ Misses 4105 4048 -57 ☔ View full report in Codecov by Sentry. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
No description provided.