Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irods/irods#7274] Add authentication configuration docs #214

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

alanking
Copy link
Contributor

In service of irods/irods#7274

Still working on the issue itself (tests are finding serious problems) but figured I would go ahead and put this up for eyeballs on the words.

@alanking
Copy link
Contributor Author

Roping in irods/irods#7357 and irods/irods#7358

@trel
Copy link
Member

trel commented Sep 29, 2023

Remove GSI and Kerberos in separate commits please.

@alanking
Copy link
Contributor Author

Hmm... okay, how do I split removing the sentence "GSI and Kerberos are also available."? There were a couple of instances like that and it wasn't clear to me how to split that up.

@trel
Copy link
Member

trel commented Sep 29, 2023

Oh - yeah that’s not as obvious. Yeah pick one for that sentence.

@alanking
Copy link
Contributor Author

When squashed, the desired effect will occur. Please let me know when we're ready for a force-push

@trel
Copy link
Member

trel commented Sep 29, 2023

go for it

@alanking
Copy link
Contributor Author

Pushed

@trel
Copy link
Member

trel commented Sep 29, 2023

Yeps. Go for it.

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and merge when ready.

@alanking alanking merged commit ced7299 into irods:main Sep 29, 2023
1 check failed
@alanking alanking deleted the 7274.m branch September 29, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants