Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irods/irods#4904] irodsPamAuthCheck: Add more docs (main) #239

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

alanking
Copy link
Contributor

Addresses irods/irods#4904

My understanding is that we have no plans to update irodsPamAuthCheck itself. If anything, we would write a different tool for use in the future if we wanted to make any changes.

Also, happy to squash down to one if we're into it.

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Pound when ready.

@korydraughn
Copy link
Collaborator

Your second commit message about the heading needs a tweak.

so this commit move the -> so this commit moves the

@alanking
Copy link
Contributor Author

Good catch. I've amended the commit message and squashed to one.

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

Adds some additional details about the irodsPamAuthCheck tool that
ships with iRODS to test whether basic PAM authentication has been
configured correctly.

The text about SSL server setup starts before the heading for setting
up the SSL server, so this commit moves the heading to just before this
section begins.
@alanking alanking merged commit 2fb8e82 into irods:main Jan 12, 2024
1 of 2 checks passed
@alanking alanking deleted the 4904.m branch January 12, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants