Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error codes to troubleshooting and a page for GenQuery #251

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

alanking
Copy link
Contributor

@alanking alanking commented Apr 5, 2024

Addresses irods/irods#6631

I already spent the time on this so I'm putting this up here, but we don't have to use it.

The only thing the issue calls for is the error codes and a page for iquest attrs, so, take what seems good and we'll throw out the rest (which could be all of it)

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Once the review comments are handled, this will be ready.

docs/system_overview/genquery.md Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
@alanking
Copy link
Contributor Author

alanking commented Apr 5, 2024

I am also aware of the ability to use or or || in GenQuery, but I am not comfortable documenting it because I don't know that I fully understand how it works. :) Should we include that or just leave it out?

@alanking alanking marked this pull request as ready for review April 5, 2024 15:10
@korydraughn
Copy link
Collaborator

Let's include it just for completeness. You can document the syntax and include a very brief statement about it being the equivalent of where CONDITIONS and (ATTRIBUTE = 'V1' or ATTRIBUTE = 'V2').

@alanking
Copy link
Contributor Author

alanking commented Apr 5, 2024

Okay, I added the || piece. I'll take a look into the order/order_desc thing to see if I can draw any conclusions.

@alanking
Copy link
Contributor Author

alanking commented Apr 9, 2024

I will squash this soon (no #s) if there are no further comments.

@korydraughn
Copy link
Collaborator

The suggestions by @trel seem good. Other than that, the PR is ready in my book.

@korydraughn
Copy link
Collaborator

Looks good. Let's squash it.

@alanking
Copy link
Contributor Author

alanking commented Apr 9, 2024

Squashed.

Adding some iRODS error codes to the Troubleshooting page so that
searching for these terms can help users.
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@alanking
Copy link
Contributor Author

alanking commented Apr 9, 2024

#'d. Mergin.

@alanking alanking merged commit 9fe9eb9 into irods:main Apr 9, 2024
1 of 2 checks passed
@alanking alanking deleted the 432-docs branch April 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants