-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenQuery2 docs and tweak to syslog docs (main) #278
Conversation
Forgot to mention logical-or and parens. Will add words about those soon. |
I think this is an acceptable start for GenQuery2 documentation. Feedback welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Squash when ready (I see you've left a note to self, so will review any additional changes as they come)
This is now ready. Waiting for the signal to squash or tweak. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good. I like the added distinctions between validation and verification of the SQL. I say squash em.
See latest commit for changes to GenQuery1 section headers. I modified those so the casing for headers is the same throughout the doc. |
All review comments have been addressed. @trel Happy to show a rendering if you're curious about the navigation depth config option. Otherwise, I believe this is ready. |
yes, let's do that live. |
Squashed and pounded. |
No description provided.