-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7947] Updated docs for checksum_read_buffer_size_in_bytes in server_… #285
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding some words to the Troubleshooting page with some key words that might lead people there who are experiencing the problem which inspired this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one last thing.
Once the final review comment is addressed, squash it.
@@ -25,6 +25,10 @@ This file defines the behavior of the server Agent that answers individual reque | |||
// Changing this value requires a server restart in order to take effect. | |||
"agent_factory_watcher_sleep_time_in_seconds": 5, | |||
|
|||
// (Optional) | |||
// The buffer size used for reading a replica during checksum calculations. | |||
"checksum_read_buffer_size_in_bytes": 1048576 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comma.
Please look over / make suggestions for wording changes.
I will also update the README for the S3 plugin to point people to this setting if they have errors on checksum calculations.