Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7947] Updated docs for checksum_read_buffer_size_in_bytes in server_… #285

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JustinKyleJames
Copy link
Contributor

Please look over / make suggestions for wording changes.

I will also update the README for the S3 plugin to point people to this setting if they have errors on checksum calculations.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding some words to the Troubleshooting page with some key words that might lead people there who are experiencing the problem which inspired this change.

docs/system_overview/configuration.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one last thing.

Once the final review comment is addressed, squash it.

@@ -25,6 +25,10 @@ This file defines the behavior of the server Agent that answers individual reque
// Changing this value requires a server restart in order to take effect.
"agent_factory_watcher_sleep_time_in_seconds": 5,

// (Optional)
// The buffer size used for reading a replica during checksum calculations.
"checksum_read_buffer_size_in_bytes": 1048576
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants