Block writing refactor #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move `setup_output_folder` to `single.py`, start consolidating output file metadata
|
Seems like the linux failing is a pydantic red-herring. Will be fixed upon bumping to version 2 shortly. |
|
The unrelated CI test failings will be fixed in upcoming PRs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New classes to better handle blockwise input/output. The complications come from the
stridesthat we provide as an output, which has no analog indask.map_blocksordask.map_overlaps, e.g.The implementation ended up being messier than initially expected @gmgunter , since we do en up having to trim outputs because our window size may be (much) larger than the
strides.