Skip to content

Commit

Permalink
Move suggest fixes to a separate CI workflow (microsoft#22415)
Browse files Browse the repository at this point in the history
Move suggest fixes to a separate CI workflow so that it is triggered
only on PRs and does not fail the main branch.
  • Loading branch information
justinchuby authored and Ishwar Raut committed Nov 19, 2024
1 parent 4a8ab03 commit 2fe57e6
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 32 deletions.
36 changes: 4 additions & 32 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
- rel-*
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name == 'workflow_dispatch' }}
cancel-in-progress: true

jobs:
optional-lint:
name: Optional Lint
Expand Down Expand Up @@ -72,38 +76,6 @@ jobs:
category: lintrunner
checkout_path: ${{ github.workspace }}

auto-apply-fixes:
name: Suggest fixes
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v5
with:
# Version range or exact version of Python to use, using SemVer's version range syntax. Reads from .python-version if unset.
python-version: "3.10"
- name: Setup Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
components: rustfmt
- name: Install dependencies
run: |
python -m pip install -r requirements-dev.txt
python -m pip install lintrunner lintrunner-adapters
lintrunner init
- name: Run lintrunner on all files
run: |
set +e
lintrunner f --all-files -v
exit 0
- uses: parkerbxyz/suggest-changes@v1
with:
comment: 'You can commit the suggested changes from lintrunner.'

lint-cpp:
name: Optional Lint C++
runs-on: ubuntu-latest
Expand Down
49 changes: 49 additions & 0 deletions .github/workflows/pr_checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Copyright (c) ONNX Project Contributors
#
# SPDX-License-Identifier: Apache-2.0

name: PR Checks

on:
pull_request:
branches:
- main

permissions: # set top-level default permissions as security best practice
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name == 'workflow_dispatch' }}
cancel-in-progress: true

jobs:
auto-apply-fixes:
name: Suggest fixes
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: Setup Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
components: rustfmt
- name: Install dependencies
run: |
python -m pip install -r requirements-dev.txt
python -m pip install lintrunner lintrunner-adapters
lintrunner init
- name: Run lintrunner on all files
run: |
set +e
lintrunner f --all-files -v
exit 0
- uses: parkerbxyz/suggest-changes@v1
with:
comment: 'You can commit the suggested changes from lintrunner.'

0 comments on commit 2fe57e6

Please sign in to comment.