Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade To Latest Filament #6511

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Upgrade To Latest Filament #6511

wants to merge 31 commits into from

Conversation

errissa
Copy link
Collaborator

@errissa errissa commented Nov 28, 2023 •
edited by ssheorey
Loading

I have marked this PR as ready for review but there are still some issues (of varying severity) that need to be resolved. Bold items below are show stoppers.

  • Intel Mac visualization windows are completely blank
  • Inconsistency between Open3DViewer and O3DVisualizer with flipped Y-axis
  • Pass CI
  • Setting background color doesn't work in Open3DViewer (but does work in O3DVisualizer).
  • Test on Windows
  • Test CPU rendering
  • Test iGPU
  • Ground mode not working (can probably be left as known issue for now)
  • Demo scene has rendering bugs (can probably be left as known issue for now)
  • Update to new APIs for post-processing effects such as tone-mapping Separate PR

Depends on #6587

This change is Reviewable

@errissa errissa requested a review from ssheorey November 28, 2023 04:48
@update-docs Update Docs
Copy link

update-docs bot commented Nov 28, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey mentioned this pull request Dec 27, 2023
Open
3 tasks
@errissa errissa marked this pull request as ready for review December 28, 2023 05:59
@ssheorey ssheorey mentioned this pull request Jan 9, 2024
Open
3 tasks
@danrauch danrauch mentioned this pull request Jan 17, 2024
Open
3 tasks
@ssheorey ssheorey assigned ssheorey and errissa and unassigned ssheorey Apr 28, 2024
@ssheorey ssheorey added this to the v0.19 milestone Apr 28, 2024
@ssheorey ssheorey mentioned this pull request Jun 19, 2024
Open
3 tasks
@ssheorey
Copy link
Member

Hangs in macOS. GLFW update PR #6587 "should" fix this.
Need to check Windows. Run through all examples.

@ssheorey ssheorey self-assigned this Aug 13, 2024
@david-jennings david-jennings mentioned this pull request Sep 18, 2024
Open
3 tasks
@ssheorey ssheorey marked this pull request as draft December 13, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssheorey ssheorey Awaiting requested review from ssheorey

At least 1 approving review is required to merge this pull request.

Assignees

@errissa errissa

@ssheorey ssheorey

Labels
rendering
Projects
Open3D 2024
Status: In progress
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@errissa @ssheorey