Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assimp to fix compilation with gcc 13 #6846

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

benjaminum
Copy link
Contributor

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Update to latest main for assimp (>5.4.1) to fix a compilation issue with GCC 13 (See assimp/assimp#5592).
Resolves the Assimp problem in #6544

Copy link

update-docs bot commented Jun 30, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested a review from errissa July 3, 2024 14:39
@ssheorey
Copy link
Member

ssheorey commented Jul 3, 2024

Check Ubuntu 18.04 / 20.04 errors.

@ssheorey ssheorey force-pushed the benjaminum/update_assimp branch from 19baf11 to c9118aa Compare July 9, 2024 16:45
@ssheorey ssheorey merged commit 02c26d9 into main Jul 9, 2024
23 of 43 checks passed
@ssheorey ssheorey deleted the benjaminum/update_assimp branch July 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants